Merge pull request #3881 from Prinzhorn/serverconnect

Only emit "serverconnect" after successfully connecting
This commit is contained in:
Maximilian Hils 2020-04-02 11:39:25 +02:00 committed by GitHub
commit 49bc7d944a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -160,10 +160,10 @@ class ServerConnectionMixin:
"""
if not self.server_conn.address:
raise exceptions.ProtocolException("Cannot connect to server, no server address given.")
self.log("serverconnect", "debug", [repr(self.server_conn.address)])
self.channel.ask("serverconnect", self.server_conn)
try:
self.server_conn.connect()
self.log("serverconnect", "debug", [repr(self.server_conn.address)])
self.channel.ask("serverconnect", self.server_conn)
except exceptions.TcpException as e:
raise exceptions.ProtocolException(
"Server connection to {} failed: {}".format(