* fix for #4852

* changelog
This commit is contained in:
Brad Dixon 2021-10-13 07:15:21 -04:00 committed by GitHub
parent d6ba6777eb
commit 77cf2ab4ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions

View File

@ -11,6 +11,7 @@
* Add `client_replay_concurrency` option, which allows more than one client replay request to be in-flight at a time. (@rbdixon) * Add `client_replay_concurrency` option, which allows more than one client replay request to be in-flight at a time. (@rbdixon)
* New content view which handles gRPC/protobuf. Allows to apply custom definitions to visualize different field decodings. * New content view which handles gRPC/protobuf. Allows to apply custom definitions to visualize different field decodings.
Includes example addon which applies custom definitions for selected gRPC traffic (@mame82) Includes example addon which applies custom definitions for selected gRPC traffic (@mame82)
* Fix a crash caused when editing string option (#4852, @rbdixon)
## 28 September 2021: mitmproxy 7.0.4 ## 28 September 2021: mitmproxy 7.0.4

View File

@ -181,7 +181,8 @@ class OptionsList(urwid.ListBox):
foc, idx = self.get_focus() foc, idx = self.get_focus()
v = self.walker.get_edit_text() v = self.walker.get_edit_text()
try: try:
d = self.master.options.parse_setval(foc.opt, v) current = getattr(self.master.options, foc.opt.name)
d = self.master.options.parse_setval(foc.opt, v, current)
self.master.options.update(**{foc.opt.name: d}) self.master.options.update(**{foc.opt.name: d})
except exceptions.OptionsError as v: except exceptions.OptionsError as v:
signals.status_message.send(message=str(v)) signals.status_message.send(message=str(v))