option refresh_server_playback -> server_replay_refresh

All other server playback options have this form.

mitmproxy/addons/serverplayback.py

@@ -131,7 +131,7 @@ class ServerPlayback:
             if rflow:
                 response = rflow.response.copy()
                 response.is_replay = True
-                if ctx.options.refresh_server_playback:
+                if ctx.options.server_replay_refresh:
                     response.refresh()
                 f.response = response
                 if not self.flowmap:

mitmproxy/options.py

@@ -65,7 +65,7 @@ class Options(optmanager.OptManager):
         onboarding_port = None  # type: int
         proxyauth = None  # type: Optional[str]
         rawtcp = None  # type: bool
-        refresh_server_playback = None  # type: bool
+        server_replay_refresh = None  # type: bool
         replacements = None  # type: Sequence[str]
         replay_kill_extra = None  # type: bool
         rfile = None  # type: Optional[str]
@@ -160,7 +160,7 @@ class Options(optmanager.OptManager):
             """
         )
         self.add_option(
-            "refresh_server_playback", bool, True,
+            "server_replay_refresh", bool, True,
             """
             Refresh server replay responses by adjusting date, expires and
             last-modified headers, as well as adjusting cookie expiration.

mitmproxy/tools/console/statusbar.py

@@ -211,7 +211,7 @@ class StatusBar(urwid.WidgetWrap):
             opts.append("anticomp")
         if self.master.options.showhost:
             opts.append("showhost")
-        if not self.master.options.refresh_server_playback:
+        if not self.master.options.server_replay_refresh:
             opts.append("norefresh")
         if self.master.options.replay_kill_extra:
             opts.append("killextra")

test/mitmproxy/addons/test_serverplayback.py

@@ -331,7 +331,7 @@ def test_server_playback_full():
     with taddons.context() as tctx:
         tctx.configure(
             s,
-            refresh_server_playback = True,
+            server_replay_refresh = True,
         )
 
         f = tflow.tflow()
@@ -363,7 +363,7 @@ def test_server_playback_kill():
     with taddons.context() as tctx:
         tctx.configure(
             s,
-            refresh_server_playback = True,
+            server_replay_refresh = True,
             replay_kill_extra=True
         )
 

test/mitmproxy/tools/console/test_statusbar.py

@@ -16,7 +16,7 @@ def test_statusbar(monkeypatch):
         anticache=True,
         anticomp=True,
         showhost=True,
-        refresh_server_playback=False,
+        server_replay_refresh=False,
         replay_kill_extra=True,
         upstream_cert=False,
         stream_large_bodies="3m",