From a568721e866ba8eee0a47f8a1067e626820891a2 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Sun, 5 Apr 2020 00:30:14 +0200 Subject: [PATCH] [sans-io] add tests for unreachable http servers --- test/mitmproxy/proxy2/layers/test_http.py | 30 +++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/test/mitmproxy/proxy2/layers/test_http.py b/test/mitmproxy/proxy2/layers/test_http.py index 87c30b7cf..b5c83bdd9 100644 --- a/test/mitmproxy/proxy2/layers/test_http.py +++ b/test/mitmproxy/proxy2/layers/test_http.py @@ -314,6 +314,36 @@ def test_request_streaming(tctx, response): assert False +@pytest.mark.parametrize("connect", [True, False]) +def test_server_unreachable(tctx, connect): + """Test the scenario where the target server is unreachable.""" + tctx.options.connection_strategy = "eager" + server = Placeholder() + flow = Placeholder() + err = Placeholder() + playbook = Playbook(http.HttpLayer(tctx, HTTPMode.regular), hooks=False) + if connect: + playbook >> DataReceived(tctx.client, b"CONNECT example.com:443 HTTP/1.1\r\n\r\n") + else: + playbook >> DataReceived(tctx.client, b"GET http://example.com/ HTTP/1.1\r\n\r\n") + + playbook << OpenConnection(server) + playbook >> reply("Connection failed") + if not connect: + # Our API isn't ideal here, there is no error hook for CONNECT requests currently. + # We could fix this either by having CONNECT request go through all our regular hooks, + # or by adding dedicated ok/error hooks. + playbook << http.HttpErrorHook(flow) + playbook >> reply() + playbook << SendData(tctx.client, err) + playbook << CloseConnection(tctx.client) + + assert playbook + assert flow().error + assert b"502 Bad Gateway" in err() + assert b"Connection failed" in err() + + @pytest.mark.parametrize("data", [ None, b"I don't speak HTTP.",