Grasscutters/mitmproxy
3
0
Fork 0
mirror of https://github.com/Grasscutters/mitmproxy.git synced 2024-11-22 07:08:10 +00:00
Code Issues Projects Releases Wiki Activity

Document Cookie header folding issues (#4618)

Browse Source 
* Document Cookie header folding issues

* plural: *exists*, me: 😮

* link list
This commit is contained in:
Alexander Prinzhorn 2021-06-03 03:11:40 +02:00 committed by GitHub
parent 27883e7b05
commit ce2d36dbab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mitmproxy/http.py
View File

@ -86,7 +86,7 @@ class Headers(multidict.MultiDict): # type: ignore
>>> h.fields
Caveats:
- For use with the "Set-Cookie" header, either use `Response.cookies` or see `Headers.get_all`.
- For use with the "Set-Cookie" and "Cookie" headers, either use `Response.cookies` or see `Headers.get_all`.
"""
def __init__(self, fields: Iterable[Tuple[bytes, bytes]] = (), **headers):
@ -142,9 +142,12 @@ class Headers(multidict.MultiDict): # type: ignore
def get_all(self, name: Union[str, bytes]) -> List[str]:
"""
Like `Headers.get`, but does not fold multiple headers into a single one.
This is useful for Set-Cookie headers, which do not support folding.
This is useful for Set-Cookie and Cookie headers, which do not support folding.
*See also:* <https://tools.ietf.org/html/rfc7230#section-3.2.2>
*See also:*
- <https://tools.ietf.org/html/rfc7230#section-3.2.2>
- <https://datatracker.ietf.org/doc/html/rfc6265#section-5.4>
- <https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.5>
"""
name = _always_bytes(name)
return [