From 4ce5e1386c7d065f4c4f8b68aa57b0e18d6945ca Mon Sep 17 00:00:00 2001 From: RamiBerm <54766858+RamiBerm@users.noreply.github.com> Date: Tue, 3 Sep 2019 17:19:50 +0300 Subject: [PATCH 1/2] Updated har_dump,py timings dictionary function the HAR file spec (http://www.softwareishard.com/blog/har-12-spec/#timings) states that timings that do not apply for a certain requests should be set to -1, this example may set -1000 as a timings value for certain requests. This ends up producing invalid HAR files in many cases. My proposed fix is to assign -1 into the dic and only multiply by 1000 for other values --- examples/complex/har_dump.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/complex/har_dump.py b/examples/complex/har_dump.py index 33a2f79f8..e09646017 100644 --- a/examples/complex/har_dump.py +++ b/examples/complex/har_dump.py @@ -87,7 +87,7 @@ def response(flow): } # HAR timings are integers in ms, so we re-encode the raw timings to that format. - timings = dict([(k, int(1000 * v)) for k, v in timings_raw.items()]) + timings = dict([(k, -1 if v is -1 else int(1000 * v)) for k, v in timings_raw.items()]) # full_time is the sum of all timings. # Timings set to -1 will be ignored as per spec. From e97a804e89454f5f5f546f3f99635ca8b99d75d3 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Thu, 5 Sep 2019 22:13:49 +0200 Subject: [PATCH 2/2] make dict comprehension more readable --- examples/complex/har_dump.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/complex/har_dump.py b/examples/complex/har_dump.py index e09646017..414b4f61f 100644 --- a/examples/complex/har_dump.py +++ b/examples/complex/har_dump.py @@ -87,7 +87,10 @@ def response(flow): } # HAR timings are integers in ms, so we re-encode the raw timings to that format. - timings = dict([(k, -1 if v is -1 else int(1000 * v)) for k, v in timings_raw.items()]) + timings = { + k: int(1000 * v) if v != -1 else -1 + for k, v in timings_raw.items() + } # full_time is the sum of all timings. # Timings set to -1 will be ignored as per spec.