From f4013dcd406c731c08c02789f80ccb364844c0ff Mon Sep 17 00:00:00 2001 From: Aldo Cortesi Date: Sun, 7 Sep 2014 12:47:17 +1200 Subject: [PATCH] Add a FIXME note for discarded credentials --- netlib/http.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/netlib/http.py b/netlib/http.py index 53a47d501..35e959cd1 100644 --- a/netlib/http.py +++ b/netlib/http.py @@ -46,6 +46,9 @@ def parse_url(url): if not scheme: return None if '@' in netloc: + # FIXME: Consider what to do with the discarded credentials here Most + # probably we should extend the signature to return these as a separate + # value. _, netloc = string.rsplit(netloc, '@', maxsplit=1) if ':' in netloc: host, port = string.rsplit(netloc, ':', maxsplit=1)