From fb54bb377763b4e57c1a092610d83a2b9ac4e6e9 Mon Sep 17 00:00:00 2001 From: kira0204 Date: Mon, 19 Feb 2018 22:45:30 +0530 Subject: [PATCH] Testing --- mitmproxy/net/http/request.py | 5 +---- test/mitmproxy/net/http/test_request.py | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/mitmproxy/net/http/request.py b/mitmproxy/net/http/request.py index 4ef6cceb1..959fdd339 100644 --- a/mitmproxy/net/http/request.py +++ b/mitmproxy/net/http/request.py @@ -429,10 +429,7 @@ class Request(message.Message): def _get_urlencoded_form(self): is_valid_content_type = "application/x-www-form-urlencoded" in self.headers.get("content-type", "").lower() if is_valid_content_type: - try: - return tuple(mitmproxy.net.http.url.decode(self.get_text(strict=False))) - except ValueError: - pass + return tuple(mitmproxy.net.http.url.decode(self.get_text(strict=False))) return () def _set_urlencoded_form(self, form_data): diff --git a/test/mitmproxy/net/http/test_request.py b/test/mitmproxy/net/http/test_request.py index 3653d0502..ef581a914 100644 --- a/test/mitmproxy/net/http/test_request.py +++ b/test/mitmproxy/net/http/test_request.py @@ -351,7 +351,7 @@ class TestRequestUtils: request.headers["Content-Type"] = "application/x-www-form-urlencoded" assert list(request.urlencoded_form.items()) == [("foobar", "baz")] request.raw_content = b"\xFF" - assert len(request.urlencoded_form) == 0 + assert len(request.urlencoded_form) == 1 def test_set_urlencoded_form(self): request = treq(content=b"\xec\xed")