Aldo Cortesi
b0b67fe2a7
commands: refactor types
...
The type system was scattered over a number of places, making it hard to
follow. This collects all command types in types.py, and completion, validation
and parsing for each type is centralised. We should use the same mechanism for
options.
2017-12-18 17:02:48 +13:00
Aldo Cortesi
7dbe4209d9
Merge pull request #2690 from cortesi/types
...
mitmproxy.types -> mitmproxy.coretypes
2017-12-18 08:14:07 +13:00
Aldo Cortesi
978b8d095c
mitmproxy.types -> mitmproxy.coretypes
...
The types name is valuable, and we have a better use for it in collecting and
exposing types for options and commands.
The coretypes module should probably be split up anyway - it contains a
threading base class, a few container objects, and the defintion of our
serialization protocol. I was tempted to rename it to "uncagegorized" for the
sake of honesty.
2017-12-17 13:31:36 +13:00
Aldo Cortesi
a289db8d75
commands: minor refactoring and command renaming
2017-12-17 11:23:15 +13:00
Aldo Cortesi
ac335057a7
Disable implicit JS test asset generation
...
The JS test assets depend in a brittle way on the details of the tflow()
utility functions. We shouldn't have to fix JS tests when adjusting these.
Options:
- Manually generate the test assets in a script.
- Define the JS assets without using tflow, so they don't unexpextedly
vary.
2017-12-17 10:17:05 +13:00
Aldo Cortesi
2649e57691
minor: fix key bindings, adjust flow command presentation
...
Fixes #2681
2017-12-17 10:11:02 +13:00
Aldo Cortesi
cd913d598d
command cuts: add completion
...
- Remove shortcuts for request, response, etc. - we don't need them if we have completion
- Restrict cuts specification to a set of prefixes
- Extend cuts to add a few more items
2017-12-17 10:11:02 +13:00
Aldo Cortesi
50a94db2cc
commands: Reassess the cuts API
...
Make the cuts API more transparent. Cut specifications are no longer a
centrally resolved core type, and flows are now passed explicitly.
2017-12-17 10:11:02 +13:00
Aldo Cortesi
198c7b19a3
commander: test++
2017-12-15 17:51:02 +13:00
Aldo Cortesi
a8ae006f2e
command: path completion
2017-12-15 16:02:34 +13:00
Aldo Cortesi
582e6a9fa6
command: recursive command parsing
...
This lets us complete commands passed to commands correctly.
2017-12-15 16:02:34 +13:00
Aldo Cortesi
a436af537a
Merge pull request #2678 from mhils/console-startup-events
...
Fix console logging during startup
2017-12-15 16:02:19 +13:00
Maximilian Hils
3ff380054c
improve eventstore truncation
2017-12-15 01:36:41 +01:00
Aldo Cortesi
1c097813c1
commands: emit types from partial parser, implement choice completion
2017-12-15 11:38:37 +13:00
Aldo Cortesi
8c0ba71fd8
commander: tab completion for command names
2017-12-15 10:07:47 +13:00
Aldo Cortesi
4d358c49fb
WIP: autocompletion
2017-12-15 10:07:47 +13:00
Aldo Cortesi
0cd4a77268
commands: add a parser for partial commands
...
We only return Cmd and str types for the moment.
2017-12-15 10:07:47 +13:00
Aldo Cortesi
e64d5c6bb9
commands: add a Cmd argument type
...
This represents a command passed as an argument. Also split arguments from
command values themselves, making the command help for meta-commands much
clearer.
2017-12-15 10:07:47 +13:00
Aldo Cortesi
04e19f9171
Introduce a custom widget for command editing
...
The builtin urwid.Edit widget is not sufficiently flexible for what we want to
do.
2017-12-15 10:07:47 +13:00
Aldo Cortesi
dfcf62ff2b
Merge pull request #2545 from mitmproxy/wsproto
...
Replace our WebSocket stack with wsproto
2017-12-15 09:49:24 +13:00
Maximilian Hils
0af6e2e97f
adjust tests
2017-12-14 15:44:47 +01:00
Aldo Cortesi
62561ed428
Merge pull request #2669 from cortesi/path
...
commands: add a Path argument type
2017-12-14 07:42:12 +13:00
Maximilian Hils
5e0e08a4d6
Merge pull request #2670 from Kriechi/fix-2664
...
fix #2664
2017-12-13 13:50:43 +01:00
Thomas Kriechbaumer
488ec6f3f1
fix #2664
2017-12-13 09:45:40 +01:00
Aldo Cortesi
79cf6d2a5d
Merge pull request #2668 from cortesi/commandopts
...
Command improvements
2017-12-13 14:42:56 +13:00
Aldo Cortesi
e63bb8cde5
commands: add a Path argument type
...
This is just an alias for str, and in this patch is used mostly to give an
appropriate type in help strings. More to come.
Fixes #2198
2017-12-13 14:41:46 +13:00
Aldo Cortesi
4cee1a4f96
commands: formalise a Choice type
...
This resolves as a string during MyPy checks, but at runtime has an additional
attribute that is a command that returns valid options.
This is very ugly and clumsy, basically because MyPy is super restrictive about
what it accepts as a type. Almost any attempt to construct these types in a
more sophisticated way fails in one way or another. I'm open to suggestions.
2017-12-13 11:08:14 +13:00
Maximilian Hils
1a45cf17b3
Merge pull request #2643 from Ga-ryo/master
...
Fix #2594
2017-12-12 22:40:47 +01:00
Ujjwal Verma
5214f544e7
Use wsproto for websockets
2017-12-12 22:09:46 +01:00
Thomas Kriechbaumer
130021b76d
prepare WebSocket stack to move to wsproto
2017-12-12 22:09:46 +01:00
Maximilian Hils
8e9194c2b4
fix #2529
2017-12-12 16:46:35 +01:00
Maximilian Hils
0fb48bc6a7
minor improvements, add tests for ipv4-mapped addresses
2017-12-12 14:00:12 +01:00
Aldo Cortesi
4912920573
Merge branch 'master' into browser-win
2017-12-12 08:03:09 +13:00
Maximilian Hils
7654ad2d31
fix browser addon on Windows
2017-12-11 10:46:55 +01:00
Aldo Cortesi
b8cbb4dce8
commands: verify command function signatures before call ( #2659 )
...
Fixes #2652 , and many other possible crashes on user input.
2017-12-11 10:03:07 +01:00
Aldo Cortesi
aeefcd08a4
browser addon: start an isolated browser attached to the proxy
...
A simple addon that starts an instance of Chrome attached to the current
proxy. The instance is isolated in its own user data directory, and addons are
turned off.
Future work:
- I wasn't able to test the Windows executable path - a Windows dev should
confirm this for us.
- In future it would be nice to support other browsers like Firefox.
2017-12-10 18:26:24 +13:00
Suraj Tripathi
5067438ec1
Bug in expected_http_body_size fix ( #2642 )
...
fixes #2618
2017-11-27 19:01:32 +01:00
Maximilian Hils
4a2a718bc2
improve clientreplay addon
...
- always refresh UI after flow is finished (refs #2616 )
- count currently active replay
- make replay thread daemonic so that users can exit mitmproxy
if replay hangs. This is not perfect yet, but vastly better
than how it has been.
2017-11-07 11:49:12 +01:00
Maximilian Hils
e6e28c2ac3
fix revert of duplicated flows
2017-11-06 15:24:54 +01:00
Maximilian Hils
7314081b82
make safecall threadsafe.
2017-10-26 21:43:59 +02:00
Maximilian Hils
4a6d838ecc
fix #2563
2017-10-24 23:27:16 +02:00
Maximilian Hils
a5d74356dd
simplify version output
2017-10-24 14:33:56 +02:00
Maximilian Hils
f31d5dc3eb
Merge pull request #2591 from ddworken/master
...
Added scanning for CSS injection and iframe injection to XSS scanner
2017-10-22 18:02:28 +02:00
Maximilian Hils
4522f15c89
skip ipv6 tests on sudo-enabled travis builds
2017-10-20 16:00:25 +02:00
David Dworken
04a06eb6b5
Added scanning for CSS injection and iframe injection
2017-10-17 23:39:33 -04:00
Maximilian Hils
289ddfe988
remove html outline contentview, fix #2572
2017-09-14 15:11:24 -07:00
Maximilian Hils
930d78b554
Merge pull request #2537 from ujjwal96/content-view
...
JS beautifier
2017-09-04 19:49:42 +02:00
Maximilian Hils
68fab8bd92
Merge pull request #2560 from mhils/mitmproxy-net-tls
...
Split TLS parts from net.tcp into net.tls
2017-09-04 17:32:49 +02:00
Maximilian Hils
de006ea8ad
move hostname validation into mitmproxy.net.tls
2017-09-04 14:02:43 +02:00
Maximilian Hils
0b79304e98
suppress tornado logging in tests
2017-09-03 21:22:21 +02:00
Maximilian Hils
e1877577bc
make split_special_areas more flexible, refs #2537
...
(cherry picked from commit 31ef7f149e4553eb9403634c0eec6de4d0123386)
2017-09-03 21:02:29 +02:00
Ujjwal Verma
8030f5003d
Added test
2017-09-03 21:02:29 +02:00
Ujjwal Verma
b05bf588e6
JS beautifier
2017-09-03 21:02:29 +02:00
Maximilian Hils
2b4f58eb44
split TLS parts from net.tcp into net.tls
2017-09-03 03:06:15 +02:00
Matthew Shao
a98dd1642c
[web] Update test for static viewer.
2017-08-30 21:15:04 +08:00
Maximilian Hils
e1af76e71f
fix strutils.split_special_areas
2017-08-26 17:04:56 +02:00
Maximilian Hils
8eb6558570
add new, faster css prettifier 🎉
2017-08-24 20:39:21 +02:00
Maximilian Hils
72ac89f666
add strutils.escape_special_areas
2017-08-24 18:57:32 +02:00
Maximilian Hils
721f7cc92e
Merge pull request #2540 from mhils/relatively-static
...
Make it possible to run static viewer in subdirectories
2017-08-22 00:59:51 +02:00
Maximilian Hils
bf243244ce
[web] make it possible to run static viewer in subdirectories
2017-08-21 23:46:48 +02:00
Maximilian Hils
ca3e98640c
fix mitmweb master shutdown, tests++
2017-08-21 21:39:40 +02:00
Maximilian Hils
fa8bc78ca8
fix tests
2017-08-21 17:35:32 +02:00
Maximilian Hils
1e379b356f
move tests...
2017-08-21 17:34:13 +02:00
Maximilian Hils
7fcc945b4f
Merge pull request #2510 from MatthewShao/static-viewer
...
[WIP][web]Static viewer converter for mitmweb
2017-08-21 15:08:25 +02:00
Matthew Shao
d008f179c3
[web] Static_viewer coverage ++.
2017-08-17 21:40:52 +08:00
Matthew Shao
af30930ae8
[web] Add tests for StaticViewer and minor fixes.
2017-08-17 11:17:15 +08:00
Maximilian Hils
a006cab5ce
Merge pull request #2489 from MatthewShao/options-into-own-addon
...
Move console-related options into their own addon
2017-08-16 22:52:02 +02:00
Maximilian Hils
74a04f41ee
improve ClientHello.alpn_protocols API
2017-08-16 14:48:46 +02:00
Matthew Shao
3f497640ab
[web] Update tests.
2017-08-16 09:42:24 +08:00
Matthew Shao
56781a0b08
Add test for AddonManager.__contains__
2017-08-08 19:43:51 +08:00
Maximilian Hils
6d9b5b0c06
Merge pull request #2502 from mhils/optmanager
...
Fix optmanager equality check and deepcopy
2017-08-07 16:22:33 +02:00
Maximilian Hils
cf135eab44
Merge pull request #2503 from ujjwal96/options
...
Improve options UX
2017-08-07 16:22:17 +02:00
Ujjwal Verma
3d79ea4358
Improve options UX
2017-08-07 00:11:44 +05:30
Maximilian Hils
aa8969b240
Merge pull request #2492 from mhils/addon-contains
...
Gracefully handle errors during script load
2017-08-05 20:04:23 +02:00
Matthew Shao
cd222ff4f9
Fix lint.
2017-08-05 09:17:38 +08:00
Maximilian Hils
e30750bf9e
fix optmanager equality check and deepcopy
2017-08-05 02:34:00 +02:00
Maximilian Hils
a9f169ca86
gracefully handle errors during script load
2017-08-05 01:40:04 +02:00
Matthew Shao
b42f5bcb9d
Update taddon and tests.
2017-08-03 18:57:54 +08:00
Thomas Kriechbaumer
0c5b56f7ce
improve proxyauth tests
2017-08-02 10:03:41 +02:00
Matthew Shao
ddffcf83ec
Update tests.
2017-08-01 23:01:58 +08:00
Maximilian Hils
e8f836425a
add LogEntry.__eq__
2017-08-01 13:42:37 +02:00
Maximilian Hils
864073f700
Merge pull request #2487 from mhils/no-option-processing
...
Remove OptManager._processed
2017-08-01 02:54:33 +02:00
Matthew Shao
2ceaa5c9ef
Update tests.
2017-08-01 08:42:51 +08:00
Maximilian Hils
1b09002edc
remove OptManager._processed
...
Instead of having the core addon do postprocessing on body_size_limit,
we add a cache to the parsing function. First, this avoids any potential issues
with options and _processed getting out of sync. As anecdotal evidence,
the previous implementation did not clear _processed when body_size_limit was
reset to None. Second, it achieves the same end result without introducing a new
concept of a "_processed" scratch space. Third, it works even if addons aren't present,
and does not require workarounds as previously present in test_http2.py.
refs https://github.com/mitmproxy/mitmproxy/pull/2484#pullrequestreview-53101507
2017-07-31 01:58:31 +02:00
Maximilian Hils
018668618e
Merge pull request #2484 from mhils/options-into-own-addon
...
Enable tool-specific options
2017-07-31 00:01:15 +02:00
Maximilian Hils
f844c68e2e
Merge pull request #2485 from mhils/silent-option-redeclaration
...
Make option redeclaration silent if signature is the same
2017-07-30 03:47:25 +02:00
Maximilian Hils
7594dac94b
Merge pull request #2482 from mhils/pure-script-load
...
Make load_script pure
2017-07-30 02:33:00 +02:00
Maximilian Hils
6a41122990
make option redeclaration silent if signature is the same
2017-07-30 02:14:44 +02:00
Maximilian Hils
ecc01b0f02
Merge pull request #2483 from mhils/ignore-imports-with-hook-names
...
Gracefully ignore imports with hook names
2017-07-30 02:04:36 +02:00
Maximilian Hils
3b8e3e4aa9
make load_script pure
2017-07-30 02:03:26 +02:00
Maximilian Hils
10ef2866ca
fix tflow.js creation on Windows.
...
Keep lineendings consistent so that running the tests does not produce
a different file on Windows.
2017-07-30 02:01:28 +02:00
Maximilian Hils
3612e7ca76
fix tool-specific cmdline
...
before this commit, all tools only exposed mitmdump cmdline arguments,
as run() contained a simple `cmdline.mitmdump()` invocation.
This fixes this, and also makes it possible to have cmdline arguments for
tool-specific options.
2017-07-30 01:49:56 +02:00
Maximilian Hils
ed1ab3f0b1
disentangle ProxyServer and Master classes.
...
The proxy server should ultimately be an addon itself and not be passed
to the Master constructor. This commit already removes the server in the majority
of instances, and also replaces a large number of ProxyConfig usages with the Options class..
2017-07-30 01:25:36 +02:00
Maximilian Hils
52da46640b
add option type hints
2017-07-29 21:51:36 +02:00
Maximilian Hils
c29c5dbee8
add OptManager.items
2017-07-29 21:51:26 +02:00
Maximilian Hils
d5c9f13121
gracefully ignore imports with hook names
2017-07-29 21:47:27 +02:00
Maximilian Hils
9ffd42edea
Merge pull request #2452 from mattweidner/add_intercept_toggle
...
Add intercept toggle feature.
2017-07-29 19:48:42 +02:00
Maximilian Hils
e79f4049aa
Merge pull request #2480 from MatthewShao/mitmweb-options
...
Fix #2448 : Improve flow_detail and verbosity options
2017-07-29 16:57:37 +02:00
Maximilian Hils
7b54ef23d5
Merge pull request #2471 from ujjwal96/traceback-fix
...
Fixed addon error in test suite
2017-07-29 16:54:22 +02:00
Matthew Shao
7cb14925fe
Update tests for the improved verbosity options.
2017-07-28 20:34:18 +08:00