Aldo Cortesi
335861f490
Merge pull request #2207 from nikofil/scripts-redirect-stdout
...
scripts: redirect stdout to ctx.log.warn
2017-03-24 14:58:33 +13:00
Nikos Filippakis
abf291b0f9
scripts: redirect stdout to ctx.log.warn
...
Redirect messages written to stdout in scripts to ctx.log.warn.
(closes #1530 )
Signed-off-by: Nikos Filippakis <nikolaos.filippakis@cern.ch>
2017-03-24 02:35:02 +01:00
Aldo Cortesi
439c113989
Merge pull request #2204 from cortesi/consoleopts
...
console options: load and save options to and from file
2017-03-24 10:05:37 +13:00
Aldo Cortesi
0d3e2c6adf
optmanager: make serialization and loading more robust
...
Also handle errors in console options manager.
2017-03-24 09:37:17 +13:00
Aldo Cortesi
eb66456d16
console: read and write options to and from file
2017-03-23 11:28:08 +13:00
Aldo Cortesi
44c3a24f8e
Don't pass malformed request objects to our error handler
2017-03-23 10:48:20 +13:00
Matthew Shao
ab2fcbef8d
Fix#2184, mitmweb -n dispalys incorrect message. ( #2187 )
...
* Fixes #2184 , python code.
* Fixes #2184 , JavaScript code.
* [web] Update Footer.jsx (#2184 )
2017-03-22 01:26:04 +01:00
Aldo Cortesi
95d9ec88ac
tox: mypy checking for entire codebase
...
Also fix a few linting errors.
2017-03-22 10:29:46 +13:00
Aldo Cortesi
cacad8373b
Make tnetstrings pass mypy
...
Mypy doesn't support recursive types yet, so we can't properly express
TSerializable nested structures. For now, we just disable type checking in the
appropriate locations.
https://github.com/python/mypy/issues/731
2017-03-20 13:09:24 +13:00
Aldo Cortesi
4ca78604af
Factor out an io module
...
Include tnetstring - we've made enough changes that this no longer belongs in
contrib.
2017-03-20 12:50:09 +13:00
Aldo Cortesi
3a8da31835
mypy all of the codebase bar tnetstring
...
In some places, this involved removing type declarations where our types were
terminally confused. The grideditor specifically needs a cleanup and
restructure.
2017-03-20 12:38:08 +13:00
Aldo Cortesi
b98ce71770
Fix sliding window type specs
2017-03-20 12:21:50 +13:00
Aldo Cortesi
2153c337e0
addons.view: we no longer have a None order state
...
This bumps coverage back to 100% for addons
2017-03-20 09:12:09 +13:00
Aldo Cortesi
b19fefd173
options: default_contentview uses lowercase
2017-03-19 14:39:16 +13:00
Aldo Cortesi
04f1a4443d
options: reraise when there's an error with a partial update
...
Fixes #2174
2017-03-19 14:36:23 +13:00
Aldo Cortesi
8d68196fd0
console: use overlay chooser to pick flow view mode
...
More consistent, and fixes status prompt overflow issue.
2017-03-19 14:13:54 +13:00
Aldo Cortesi
1b6bc874b5
console options: "d" to reset this option to default
2017-03-19 14:01:32 +13:00
Aldo Cortesi
43e7b9d68c
options: choices for content views and tighten console order spec
...
Also clean up some leftovers from filter option name change.
2017-03-19 13:39:28 +13:00
Aldo Cortesi
22d7c31ea8
dumper, mitmdump: kill filtstr
...
Dumper now also uses view_filter. Passing arguments to mitmdump is now
precisely equivalent to setting both filestream_filter and view_filter.
2017-03-19 13:21:46 +13:00
Aldo Cortesi
475a4e3eb0
streamfile: add streamfile_filter and use it instead of filtstr
2017-03-19 13:08:26 +13:00
Aldo Cortesi
6f745b90a8
console options: fix bug that caused keys to be handled by wrong component
2017-03-19 13:05:27 +13:00
Aldo Cortesi
b1ef4bce30
options: filter -> view_filter
2017-03-19 13:02:51 +13:00
Aldo Cortesi
cb18c91f13
console options: help for overlays, improved layout for overlay grid editor
2017-03-19 12:14:42 +13:00
Aldo Cortesi
49b0a67eb9
console options: add an overlay grid editor for sequence options
2017-03-19 10:32:22 +13:00
Aldo Cortesi
4e24c95a61
optmanager: cope with bound methods in .subscribe
...
Fixes #2122
2017-03-19 10:32:22 +13:00
Aldo Cortesi
3f50d5fdbb
console options: handle choices settings
...
This implements a generic chooser overlay, and uses it to handle setting
options that have fixed choices. We'll use this overlay elsewhere too.
2017-03-19 10:32:22 +13:00
Aldo Cortesi
fea08ef919
console options: in-place editor for simple strings and ints
2017-03-19 10:32:22 +13:00
Aldo Cortesi
3a949f35f8
console options: better defaults display, g/G/D keyboard shortcuts
2017-03-19 10:32:22 +13:00
Aldo Cortesi
d759150734
console: options/help pane switching, toggle bools with enter
2017-03-19 10:32:22 +13:00
Aldo Cortesi
8130b9880a
options cleanups
...
- Move default client ciphers - no need to have a 10-line string default.
- Add some style guidance on options help
- Be consistent about reflowing options help
2017-03-19 10:32:22 +13:00
Aldo Cortesi
bc67cee687
console: sketch out look and feel of the new Options editor
2017-03-19 10:32:22 +13:00
Aldo Cortesi
39659c7528
Make mypy succeed with imports on master.py
...
We get little benefit from our mypy QA checks at the moment, because we skip
imports. This patch is what's needed to make mypy succeed with imports on a
single file: master.py
It also updates mypy to the current version, and enables a QA check.
Mypy bugs I encountered:
dict.update with kwargs not supported:
https://github.com/python/mypy/issues/1031
property setters and getters must be adjacent:
https://github.com/python/mypy/issues/1465
2017-03-19 10:32:22 +13:00
Aldo Cortesi
5192810ff6
Make mypy succeed with imports on master.py
...
We get little benefit from our mypy QA checks at the moment, because we skip
imports. This patch is what's needed to make mypy succeed with imports on a
single file: master.py
It also updates mypy to the current version, and enables a QA check.
Mypy bugs I encountered:
dict.update with kwargs not supported:
https://github.com/python/mypy/issues/1031
property setters and getters must be adjacent:
https://github.com/python/mypy/issues/1465
2017-03-17 08:13:47 +13:00
Aldo Cortesi
c5e0dc64b9
Rip out master handler mechanism
...
All events are now handled by addons, and we no longer support any events on
master.
2017-03-16 18:33:24 +13:00
Aldo Cortesi
1410cbb4b6
Remove test handlers by using taddons.RecordingMaster
...
This also means expanding and tweaking the recording master API, which we
reflect through the current test suite
2017-03-16 18:05:57 +13:00
Aldo Cortesi
85ddc5056b
Move mitmproxy console handlers to addon
2017-03-16 18:05:57 +13:00
Aldo Cortesi
b6abe96202
Move dump handlers to addon
2017-03-16 18:05:57 +13:00
Aldo Cortesi
b275257553
Merge pull request #2167 from mhils/update-dependencies
...
update mypy
2017-03-16 18:05:35 +13:00
Aldo Cortesi
1e6c51c698
Merge pull request #2152 from cortesi/readfile
...
Extract flow reading into addons
2017-03-16 15:51:21 +13:00
Maximilian Hils
112233891d
update mypy
2017-03-15 23:10:21 +01:00
Aldo Cortesi
228a22b3c0
Add a light-weight custom event system, use it for keepserving
...
This patch implements the lightweight event system I propose in #2144 , adds a
custom event "processing_complete" that is triggered after file read, client
replay and server replay, and introduces a KeepServing addon to handle this for
mitmdump.
2017-03-16 11:07:00 +13:00
Aldo Cortesi
169068c7ec
Clean up addonmanager interface
...
Clarify the plethora of invocation methods we've sprouted, correct some usages
in the codebase.
2017-03-16 08:50:29 +13:00
Maximilian Hils
65c4a3cf1d
add Request.make
2017-03-15 14:06:00 +01:00
Aldo Cortesi
ef582333ff
Extract flow reading into addons
...
This patch moves the final pieces of master functionality into addons.
- Add a ReadFile addon to read from file
- Add a separate ReadStdin addon to read from stdin, only used by mitmdump
- Remove all methods that know about io and serialization from master.Master
2017-03-15 13:44:48 +13:00
Aldo Cortesi
eba6d4359c
Merge pull request #2098 from iharsh234/bug-2086-2
...
Fix crash when duplicating flow
2017-03-15 09:20:33 +13:00
Maximilian Hils
30797755fb
stateobject: automatically change id when copying
2017-03-14 17:08:40 +01:00
Maximilian Hils
375680a3be
add connection ids
2017-03-14 17:08:40 +01:00
Maximilian Hils
2d016775fe
Merge pull request #2149 from mhils/multidictview-copy
...
Add MultiDictView.copy()
2017-03-14 14:38:38 +01:00
Maximilian Hils
0de8f46c6e
Merge pull request #2145 from mhils/ne
...
py3: __ne__ delegates to __eq__ by default
2017-03-14 14:38:00 +01:00
dequis
f351d0a307
Match ~d and ~u filters against pretty_host too
...
Changed the ~u filter in the console UI to match the behavior of
mitmweb, which only matches against pretty_url, never against url.
2017-03-14 01:57:22 -03:00
Aldo Cortesi
1f37743549
Merge pull request #2142 from mhils/2140
...
Fix #2140
2017-03-14 14:24:53 +13:00
Maximilian Hils
961747c4bc
Merge pull request #2120 from ujjwal96/replace-from-file
...
Replace from file through replacement editor #1458
2017-03-14 02:23:31 +01:00
Maximilian Hils
30fd285ec7
multidictviews should not be serializable
2017-03-14 02:20:24 +01:00
Maximilian Hils
de1de3f626
add MultiDictView.copy
2017-03-14 02:18:02 +01:00
Maximilian Hils
875ce8c9c1
py3: __ne__ delegates to __eq__ by default
2017-03-14 00:40:15 +01:00
Aldo Cortesi
1b301ad5bb
Move running() in to .tick() method to make sure it's called consistently
2017-03-14 11:41:20 +13:00
Aldo Cortesi
b745428b5c
Enable custom options in config files
...
We also now ignore unknown options in config files by default, and print a
warning if verbosity is incremented.
2017-03-14 09:40:33 +13:00
Aldo Cortesi
2832e790fd
Move serialization methods out of Options
...
Attributes on options share a namespace with options themselves. It's getting
too crowded on our Options object, so let's shift some obvious stuff into the
module.
2017-03-14 08:34:25 +13:00
Aldo Cortesi
c24f7d8e12
Optmanager: handle unknown options in value sets
2017-03-14 08:32:19 +13:00
Aldo Cortesi
75f83ba380
Show custom addon options in --options output
2017-03-14 08:32:19 +13:00
Aldo Cortesi
0c6663d0d5
Enable custom options for addons
...
- Add an options parameter to the start() event. This is to be used by addons
on startup to add custom options.
- Add a running() event that is called once the proxy is up and running.
- With the new paradigm we can't log during master __init__, so add a tiny
termstatus addon to print proxy status to terminal once we're running.
2017-03-14 08:32:19 +13:00
Maximilian Hils
2c6dcac97f
fix #2140
2017-03-13 18:37:11 +01:00
Maximilian Hils
517aef1557
decouple mitmproxy and file format version
2017-03-13 16:46:07 +01:00
Maximilian Hils
05e11547f5
Merge remote-tracking branch 'origin/master' into pr-2120
...
Conflicts:
test/mitmproxy/addons/test_replace.py
2017-03-12 23:33:49 +01:00
Maximilian Hils
0f4b523868
replacements: error right away when file does not exist
2017-03-12 23:28:49 +01:00
Thomas Kriechbaumer
1b045d24bc
nuke tutils.tmpdir, use pytest tmpdir
2017-03-12 22:55:22 +01:00
harsh vijay
a8f7c30aa0
Fix crash when duplicating flow
2017-03-13 02:23:52 +05:30
harsh vijay
9a88594684
Fix crash when duplicating flow ( #2 )
2017-03-13 01:55:50 +05:30
Maximilian Hils
4684617d2c
minor fixes
2017-03-12 20:24:50 +01:00
Ujjwal Verma
7f5fc0fdbd
Removed ReplaceBase
2017-03-12 22:10:49 +05:30
Maximilian Hils
39154e628e
Merge pull request #2118 from lymanZerga11/patch-3
...
Update proxyauth.py to add proxyauth metadata
2017-03-11 03:04:38 +01:00
Thomas Kriechbaumer
e9746c5182
Merge pull request #2114 from mitmproxy/fix-websocket-serialization
...
make websocket flows serializable
2017-03-10 21:15:46 +01:00
Thomas Kriechbaumer
49e0f23848
use flow.id to link websocket + handshake flows
2017-03-10 19:38:50 +01:00
Maximilian Hils
f3df4855af
fix type hints
2017-03-10 19:15:44 +01:00
Thomas Kriechbaumer
45bf1ff64d
disable h2c prior knowledge connections
2017-03-10 11:37:25 +01:00
Thomas Kriechbaumer
b1dd86d7ae
make websocket flows serializable
...
fixes #2113
2017-03-09 19:08:59 +01:00
Ujjwal Verma
25703f8c53
Fixed Replacement test
2017-03-09 23:33:11 +05:30
Ujjwal Verma
07a8c4987a
Removed replace-from-file option.Made requested changes
2017-03-09 23:20:35 +05:30
Aldo Cortesi
53178f35be
Send change event when options are reset
2017-03-09 08:53:36 +13:00
Maximilian Hils
b345f5d432
typing.Type -> type
...
`typing.Type` should have been `typing.Type[Any]`,
which in turn is equivalent to `type`
2017-03-08 15:17:45 +01:00
Maximilian Hils
63179d9751
core -> core_option_validation
...
longer, but much clearer for devs who are unfamiliar with the codebase.
2017-03-08 15:17:07 +01:00
Maximilian Hils
618e0c6265
add type hints
2017-03-08 15:10:06 +01:00
lymanZerga11
716306538f
Update proxyauth.py
2017-03-08 13:59:43 +08:00
lymanZerga11
cf83cbf2df
Update proxyauth.py
2017-03-08 11:34:59 +08:00
Maximilian Hils
f276c7a80d
change add_option parameter order
...
name, type, value matches natural language ($x is a bool with a default value of $y)
and also matches the python type annotation order of name: type = value
2017-03-08 00:52:37 +01:00
Maximilian Hils
8707928b16
unify server spec parsing
2017-03-08 00:18:34 +01:00
Aldo Cortesi
f0d6237a96
Merge remote-tracking branch 'upstream/master' into options
2017-03-08 08:22:49 +13:00
Maximilian Hils
88d48e38af
Revert "clearly indentify git-checkout as dev version"
...
This temporarily reverts commit 3b4d8d6eca
,
which broke the snapshot builds.
2017-03-07 14:49:52 +01:00
Maximilian Hils
96b798615c
Merge pull request #2106 from davidpshaw/python_3_to_master
...
Updated for python 3
2017-03-07 12:12:47 +01:00
Aldo Cortesi
98ec3b77fe
Carefully re-add a small number of short flags
...
The mechanism for booleans attaches the short flag to whatever the opposite of
the default is.
2017-03-07 21:01:21 +13:00
Aldo Cortesi
aed780bf48
Change the way proxy authetication is specified
...
We now have one option "proxyauth". If this is "any", we accept any
credentials, if it starts with an @ it's treated as a path to an htpasswd file,
if it is of the form username:password it's a single-user credential.
2017-03-07 20:18:30 +13:00
Aldo Cortesi
b0ba765598
Add type and choices to options dump commets.
2017-03-07 19:29:08 +13:00
Aldo Cortesi
320d8848ab
Options tweaks
...
- Regularise presentation and wording
- Help is mandatory for all options
- Auto-generate wording to say that sequence options can be passed multiple
times on the command-line
2017-03-07 15:23:46 +13:00
Aldo Cortesi
10db254791
Remove less commonly used command-line options
...
We now have --set, so only options that really deserve it get a dedicated flag.
I'm inclined to strip this back even more. Feel free to argue that YOUR
favourite option deserves special treatment here.
2017-03-07 14:46:28 +13:00
Aldo Cortesi
ac3b0d69cc
Add the --set option to set options directly
...
The --set option is a universal flag for setting options. Some examples:
Turn on a boolean:
mitmdump --set onboarding=false
Add a value to a sequence:
mitumdupm --set setheaders=/foo/bar/voing
Zero a sequence:
mitumdupm --set setheaders
2017-03-07 14:27:50 +13:00
Aldo Cortesi
79f5883c2f
Option spacing and coverage
2017-03-07 13:47:39 +13:00
Aldo Cortesi
99a6b0dbc1
Add --options that dumps annotated option defaults
2017-03-07 13:16:28 +13:00
Maximilian Hils
193c707061
Merge pull request #2104 from lymanZerga11/patch-2
...
Fixes #2102
2017-03-06 23:33:33 +01:00
Maximilian Hils
8b79892246
Merge pull request #2105 from Kriechi/dev-version
...
clearly indentify git-checkout as dev version
2017-03-06 23:32:59 +01:00
David Shaw
5d82068218
Updated for python 3
2017-03-06 17:30:40 -05:00