PaiGramTeam/SIMNet
3
0
Fork 0
mirror of https://github.com/PaiGramTeam/SIMNet.git synced 2024-11-25 07:36:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

🎨 Update CalculatorTalent.type function signature

Browse Source 
Update the function signature of `CalculatorTalent.type` to support `None` as a valid value in Python 3.9.
This commit is contained in:
洛水居室 2023-05-11 16:37:34 +08:00
parent 009f74839f
commit 9731216a08
No known key found for this signature in database
GPG Key ID: C9DE87DA724B88FC
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
simnet/models/genshin/calculator.py
View File

@ -186,11 +186,11 @@ class CalculatorTalent(APIModel):
max_level: int
@property
def type(self) -> Literal["attack", "skill", "burst", "passive", "dash"] | None:
def type(self) -> Optional[Literal["attack", "skill", "burst", "passive", "dash"]]:
"""The type of the talent, parsed from the group ID.
Returns:
Literal["attack", "skill", "burst", "passive", "dash"] | None: The type of the talent.
Optional[Literal["attack", "skill", "burst", "passive", "dash"]]: The type of the talent.
Returns `None` if the type cannot be determined.
"""
# special cases
@ -259,9 +259,7 @@ class CalculatorCharacterDetails(APIModel):
artifacts: List[CalculatorArtifact] = Field(alias="reliquary_list")
@validator("talents")
def correct_talent_current_level(
cls, v: List[CalculatorTalent]
) -> List[CalculatorTalent]:
def correct_talent_current_level(cls, v: List[CalculatorTalent]) -> List[CalculatorTalent]:
"""Validates the current level of each calculator talent in the talents list and sets it to 1 if it is 0.
Args: