fix: file api

src/common/helper.ts

@@ -25,29 +25,31 @@ export async function solveAsyncProblem<T extends (...args: any[]) => Promise<an
 }
 
 export class FileNapCatOneBotUUID {
-    static encodeModelId(peer: Peer, modelId: string): string {
+    static encodeModelId(peer: Peer, modelId: string, fileId: string): string {
-        return `NapCatOneBot-ModelIdFile-${peer.chatType}-${peer.peerUid}-${modelId}`;
+        return `NapCatOneBot|ModelIdFile|${peer.chatType}|${peer.peerUid}|${modelId}|${fileId}`;
     }
 
     static decodeModelId(uuid: string): undefined | {
         peer: Peer,
-        modelId: string
+        modelId: string,
+        fileId: string
     } {
-        if (!uuid.startsWith('NapCatOneBot-ModelIdFile-')) return undefined;
+        if (!uuid.startsWith('NapCatOneBot|ModelIdFile|')) return undefined;
-        const data = uuid.split('-');
+        const data = uuid.split('|');
-        if (data.length !== 5) return undefined;
+        if (data.length !== 6) return undefined;
-        const [, , chatType, peerUid, modelId] = data;
+        const [, , chatType, peerUid, modelId,fileId] = data;
         return {
             peer: {
                 chatType: chatType as any,
                 peerUid: peerUid,
             },
             modelId,
+            fileId
         };
     }
 
     static encode(peer: Peer, msgId: string, elementId: string): string {
-        return `NapCatOneBot-MsgFile-${peer.chatType}-${peer.peerUid}-${msgId}-${elementId}`;
+        return `NapCatOneBot|MsgFile|${peer.chatType}|${peer.peerUid}|${msgId}|${elementId}`;
     }
 
     static decode(uuid: string): undefined | {
@@ -55,8 +57,8 @@ export class FileNapCatOneBotUUID {
         msgId: string,
         elementId: string
     } {
-        if (!uuid.startsWith('NapCatOneBot-MsgFile-')) return undefined;
+        if (!uuid.startsWith('NapCatOneBot|MsgFile|')) return undefined;
-        const data = uuid.split('-');
+        const data = uuid.split('|');
         if (data.length !== 6) return undefined;
         const [, , chatType, peerUid, msgId, elementId] = data;
         return {

src/onebot/action/file/DelGroupFile.ts

@@ -1,23 +0,0 @@
-import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
-import { ActionName } from '../types';
-
-const SchemaData = {
-    type: 'object',
-    properties: {
-        group_id: { type: ['string', 'number'] },
-        file_id: { type: 'string' },
-    },
-    required: ['group_id', 'file_id'],
-} as const satisfies JSONSchema;
-
-type Payload = FromSchema<typeof SchemaData>;
-
-export class DelGroupFile extends BaseAction<Payload, any> {
-    actionName = ActionName.DelGroupFile;
-    payloadSchema = SchemaData;
-
-    async _handle(payload: Payload) {
-        return await this.core.apis.GroupApi.DelGroupFile(payload.group_id.toString(), [payload.file_id]);
-    }
-}

src/onebot/action/file/DelGroupFileFolder.ts

@@ -1,24 +0,0 @@
-import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
-import { ActionName } from '../types';
-
-const SchemaData = {
-    type: 'object',
-    properties: {
-        group_id: { type: ['string', 'number'] },
-        folder_id: { type: 'string' },
-    },
-    required: ['group_id', 'folder_id'],
-} as const satisfies JSONSchema;
-
-type Payload = FromSchema<typeof SchemaData>;
-
-export class DelGroupFileFolder extends BaseAction<Payload, any> {
-    actionName = ActionName.DelGroupFileFolder;
-    payloadSchema = SchemaData;
-
-    async _handle(payload: Payload) {
-        return (await this.core.apis.GroupApi.DelGroupFileFolder(
-            payload.group_id.toString(), payload.folder_id)).groupFileCommonResult;
-    }
-}

src/onebot/action/file/GetGroupFileCount.ts

@@ -1,23 +0,0 @@
-import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
-import { ActionName } from '../types';
-
-const SchemaData = {
-    type: 'object',
-    properties: {
-        group_id: { type: ['string', 'number'] },
-    },
-    required: ['group_id'],
-} as const satisfies JSONSchema;
-
-type Payload = FromSchema<typeof SchemaData>;
-
-export class GetGroupFileCount extends BaseAction<Payload, { count: number }> {
-    actionName = ActionName.GetGroupFileCount;
-    payloadSchema = SchemaData;
-
-    async _handle(payload: Payload) {
-        const ret = await this.core.apis.GroupApi.getGroupFileCount([payload.group_id?.toString()]);
-        return { count: ret.groupFileCounts[0] };
-    }
-}

src/onebot/action/file/GetGroupFileList.ts

@@ -1,50 +0,0 @@
-import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
-import { ActionName } from '../types';
-import { FileNapCatOneBotUUID } from '@/common/helper';
-
-const SchemaData = {
-    type: 'object',
-    properties: {
-        group_id: { type: ['string', 'number'] },
-        start_index: { type: ['string', 'number'] },
-        file_count: { type: ['string', 'number'] },
-        folder_id: { type: ['string', 'number'] },
-    },
-    required: ['group_id', 'start_index', 'file_count'],
-} as const satisfies JSONSchema;
-
-type Payload = FromSchema<typeof SchemaData>;
-
-export class GetGroupFileList extends BaseAction<Payload, { FileList: Array<any> }> {
-    actionName = ActionName.GetGroupFileList;
-    payloadSchema = SchemaData;
-
-    async _handle(payload: Payload) {
-        let param = {};
-        if (payload.folder_id) {
-            param = {
-                folderId: payload.folder_id.toString(),
-            };
-        }
-        const ret = await this.core.apis.MsgApi.getGroupFileList(payload.group_id.toString(), {
-            sortType: 1,
-            fileCount: +payload.file_count,
-            startIndex: +payload.start_index,
-            sortOrder: 2,
-            showOnlinedocFolder: 0,
-            ...param
-        }).catch(() => {
-            return [];
-        });
-        ret.forEach((e) => {
-            const fileModelId = e?.fileInfo?.fileModelId;
-            if (fileModelId)
-                e.fileInfo!.fileId = FileNapCatOneBotUUID.encodeModelId({
-                    chatType: 2,
-                    peerUid: payload.group_id.toString()
-                }, fileModelId);
-        });
-        return { FileList: ret };
-    }
-}

src/onebot/action/file/SetGroupFileFolder.ts

@@ -1,23 +0,0 @@
-import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
-import { ActionName } from '../types';
-
-const SchemaData = {
-    type: 'object',
-    properties: {
-        group_id: { type: ['string', 'number'] },
-        folder_name: { type: 'string' },
-    },
-    required: ['group_id', 'folder_name'],
-} as const satisfies JSONSchema;
-
-type Payload = FromSchema<typeof SchemaData>;
-
-export class SetGroupFileFolder extends BaseAction<Payload, any> {
-    actionName = ActionName.SetGroupFileFolder;
-    payloadSchema = SchemaData;
-
-    async _handle(payload: Payload) {
-        return (await this.core.apis.GroupApi.CreatGroupFileFolder(payload.group_id.toString(), payload.folder_name)).resultWithGroupItem;
-    }
-}

src/onebot/action/go-cqhttp/CreateGroupFileFolder.ts

@@ -1,10 +1,6 @@
 import { FromSchema, JSONSchema } from 'json-schema-to-ts';
 import BaseAction from '../BaseAction';
 import { ActionName } from '../types';
-import { NapCatOneBot11Adapter } from '@/onebot';
-import { NapCatCore } from '@/core';
-import { SetGroupFileFolder } from '@/onebot/action/file/SetGroupFileFolder';
-
 const SchemaData = {
     type: 'object',
     properties: {
@@ -16,17 +12,10 @@ const SchemaData = {
 
 type Payload = FromSchema<typeof SchemaData>;
 
-export class CreateGroupFileFolder extends BaseAction<Payload, null> {
+export class CreateGroupFileFolder extends  BaseAction<Payload, any>  {
     actionName = ActionName.GoCQHTTP_CreateGroupFileFolder;
     payloadSchema = SchemaData;
-
-    constructor(obContext: NapCatOneBot11Adapter, core: NapCatCore,
-                private ncSetGroupFileFolderImpl: SetGroupFileFolder) {
-        super(obContext, core);
-    }
-
     async _handle(payload: Payload) {
-        await this.ncSetGroupFileFolderImpl._handle(payload);
+        return (await this.core.apis.GroupApi.CreatGroupFileFolder(payload.group_id.toString(), payload.folder_name)).resultWithGroupItem;
-        return null;
     }
 }

src/onebot/action/go-cqhttp/DeleteGroupFile.ts

@@ -1,10 +1,7 @@
 import { FromSchema, JSONSchema } from 'json-schema-to-ts';
 import BaseAction from '../BaseAction';
 import { ActionName } from '../types';
-import { NapCatCore } from '@/core';
+import { FileNapCatOneBotUUID } from '@/common/helper';
-import { NapCatOneBot11Adapter } from '@/onebot';
-import { DelGroupFile } from '@/onebot/action/file/DelGroupFile';
-
 const SchemaData = {
     type: 'object',
     properties: {
@@ -16,17 +13,12 @@ const SchemaData = {
 
 type Payload = FromSchema<typeof SchemaData>;
 
-export class DeleteGroupFile extends BaseAction<Payload, null> {
+export class DeleteGroupFile extends BaseAction<Payload, any> {
     actionName = ActionName.GOCQHTTP_DeleteGroupFile;
     payloadSchema = SchemaData;
-
-    constructor(obContext: NapCatOneBot11Adapter, core: NapCatCore,
-                private ncDelGroupFileImpl: DelGroupFile) {
-        super(obContext, core);
-    }
-
     async _handle(payload: Payload) {
-        await this.ncDelGroupFileImpl._handle(payload);
+        const data = FileNapCatOneBotUUID.decodeModelId(payload.file_id);
-        return null;
+        if (!data) throw new Error('Invalid file_id');
+        return await this.core.apis.GroupApi.DelGroupFile(payload.group_id.toString(), [data.fileId]);
     }
 }

src/onebot/action/go-cqhttp/DeleteGroupFileFolder.ts

@@ -1,9 +1,6 @@
 import { FromSchema, JSONSchema } from 'json-schema-to-ts';
-import BaseAction from '../BaseAction';
 import { ActionName } from '../types';
-import { NapCatCore } from '@/core';
+import BaseAction from '../BaseAction';
-import { NapCatOneBot11Adapter } from '@/onebot';
-import { DelGroupFileFolder } from '@/onebot/action/file/DelGroupFileFolder';
 
 const SchemaData = {
     type: 'object',
@@ -16,17 +13,11 @@ const SchemaData = {
 
 type Payload = FromSchema<typeof SchemaData>;
 
-export class DeleteGroupFileFolder extends BaseAction<Payload, null> {
+export class DeleteGroupFileFolder extends BaseAction<Payload, any>  {
     actionName = ActionName.GoCQHTTP_DeleteGroupFileFolder;
     payloadSchema = SchemaData;
-
-    constructor(obContext: NapCatOneBot11Adapter, core: NapCatCore,
-                private ncDelGroupFileFolderImpl: DelGroupFileFolder) {
-        super(obContext, core);
-    }
-
     async _handle(payload: Payload) {
-        await this.ncDelGroupFileFolderImpl._handle(payload);
+        return (await this.core.apis.GroupApi.DelGroupFileFolder(
-        return null;
+            payload.group_id.toString(), payload.folder_id)).groupFileCommonResult;
     }
 }

src/onebot/action/go-cqhttp/GetGroupFilesByFolder.ts

@@ -1,43 +1,27 @@
 import { FromSchema, JSONSchema } from 'json-schema-to-ts';
 import BaseAction from '../BaseAction';
 import { ActionName } from '../types';
-import { NapCatOneBot11Adapter, OB11GroupFile } from '@/onebot';
-import { NapCatCore } from '@/core';
-import { GetGroupRootFiles } from '@/onebot/action/go-cqhttp/GetGroupRootFiles';
 import { OB11Entities } from '@/onebot/entities';
-
 const SchemaData = {
     type: 'object',
     properties: {
         group_id: { type: ['string', 'number'] },
         folder_id: { type: 'string' },
+        file_count: { type: ['string', 'number'] },
     },
     required: ['group_id', 'folder_id'],
 } as const satisfies JSONSchema;
 
 type Payload = FromSchema<typeof SchemaData>;
 
-export class GetGroupFilesByFolder extends BaseAction<Payload, {
+export class GetGroupFilesByFolder extends BaseAction<any, any> {
-    files: OB11GroupFile[],
-    folders: [] // QQ does not allow nested folders
-}> {
     actionName = ActionName.GoCQHTTP_GetGroupFilesByFolder;
     payloadSchema = SchemaData;
-
-    constructor(obContext: NapCatOneBot11Adapter, core: NapCatCore,
-                private getGroupRootFilesImpl: GetGroupRootFiles) {
-        super(obContext, core);
-    }
-
     async _handle(payload: Payload) {
-        const folder = (await this.getGroupRootFilesImpl._handle({ group_id: payload.group_id }))
+
-            .folders.find(folder => folder.folder_id === payload.folder_id);
-        if (!folder) {
-            throw new Error('Folder not found');
-        }
         const ret = await this.core.apis.MsgApi.getGroupFileList(payload.group_id.toString(), {
             sortType: 1,
-            fileCount: folder.total_file_count,
+            fileCount: +(payload.file_count ?? 50),
             startIndex: 0,
             sortOrder: 2,
             showOnlinedocFolder: 0,

src/onebot/action/go-cqhttp/GetGroupRootFiles.ts

@@ -1,15 +1,14 @@
 import { FromSchema, JSONSchema } from 'json-schema-to-ts';
 import BaseAction from '../BaseAction';
 import { ActionName } from '../types';
-import { NapCatOneBot11Adapter, OB11GroupFile, OB11GroupFileFolder } from '@/onebot';
+import { OB11GroupFile, OB11GroupFileFolder } from '@/onebot';
-import { NapCatCore } from '@/core';
-import { GetGroupFileCount } from '@/onebot/action/file/GetGroupFileCount';
 import { OB11Entities } from '@/onebot/entities';
 
 const SchemaData = {
     type: 'object',
     properties: {
         group_id: { type: ['string', 'number'] },
+        file_count: { type: ['string', 'number'] },
     },
     required: ['group_id'],
 } as const satisfies JSONSchema;
@@ -22,16 +21,10 @@ export class GetGroupRootFiles extends BaseAction<Payload, {
 }> {
     actionName = ActionName.GoCQHTTP_GetGroupRootFiles;
     payloadSchema = SchemaData;
-
-    constructor(obContext: NapCatOneBot11Adapter, core: NapCatCore,
-                private ncGetGroupFileCountImpl: GetGroupFileCount) {
-        super(obContext, core);
-    }
-
     async _handle(payload: Payload) {
         const ret = await this.core.apis.MsgApi.getGroupFileList(payload.group_id.toString(), {
             sortType: 1,
-            fileCount: (await this.ncGetGroupFileCountImpl._handle({ group_id: payload.group_id.toString() })).count,
+            fileCount: +(payload.file_count ?? 50),
             startIndex: 0,
             sortOrder: 2,
             showOnlinedocFolder: 0,

src/onebot/action/index.ts

@@ -55,12 +55,7 @@ import { GoCQHTTPHandleQuickAction } from './go-cqhttp/QuickAction';
 import { GetGroupIgnoredNotifies } from './group/GetGroupIgnoredNotifies';
 import { GetOnlineClient } from './go-cqhttp/GetOnlineClient';
 import { IOCRImage, OCRImage } from './extends/OCRImage';
-import { GetGroupFileCount } from './file/GetGroupFileCount';
-import { GetGroupFileList } from './file/GetGroupFileList';
 import { TranslateEnWordToZn } from './extends/TranslateEnWordToZn';
-import { SetGroupFileFolder } from './file/SetGroupFileFolder';
-import { DelGroupFile } from './file/DelGroupFile';
-import { DelGroupFileFolder } from './file/DelGroupFileFolder';
 import { SetQQProfile } from './go-cqhttp/SetQQProfile';
 import { ShareGroupEx, SharePeer } from './extends/ShareContact';
 import { CreateCollection } from './extends/CreateCollection';
@@ -92,11 +87,6 @@ import { GetGroupFilesByFolder } from '@/onebot/action/go-cqhttp/GetGroupFilesBy
 export type ActionMap = Map<string, BaseAction<any, any>>;
 
 export function createActionMap(obContext: NapCatOneBot11Adapter, core: NapCatCore): ActionMap {
-    const ncDelGroupFile = new DelGroupFile(obContext, core);
-    const ncSetGroupFileFolder = new SetGroupFileFolder(obContext, core);
-    const ncDelGroupFileFolder = new DelGroupFileFolder(obContext, core);
-    const ncGetGroupFileCount = new GetGroupFileCount(obContext, core);
-    const goCqHttpGetGroupRootFiles = new GetGroupRootFiles(obContext, core, ncGetGroupFileCount);
 
     const actionHandlers = [
         new GetGroupInfoEx(obContext, core),
@@ -113,11 +103,7 @@ export function createActionMap(obContext: NapCatOneBot11Adapter, core: NapCatCo
         new MarkPrivateMsgAsRead(obContext, core),
         new SetQQAvatar(obContext, core),
         new TranslateEnWordToZn(obContext, core),
-        ncGetGroupFileCount,
+        new GetGroupRootFiles(obContext, core),
-        new GetGroupFileList(obContext, core),
-        ncSetGroupFileFolder,
-        ncDelGroupFile,
-        ncDelGroupFileFolder,
         // onebot11
         new SendLike(obContext, core),
         new GetMsg(obContext, core),
@@ -185,12 +171,11 @@ export function createActionMap(obContext: NapCatOneBot11Adapter, core: NapCatCo
         new SetInputStatus(obContext, core),
         new GetCSRF(obContext, core),
         new DelGroupNotice(obContext, core),
-        new DeleteGroupFile(obContext, core, ncDelGroupFile),
+        new DeleteGroupFile(obContext, core),
-        new CreateGroupFileFolder(obContext, core, ncSetGroupFileFolder),
+        new CreateGroupFileFolder(obContext, core),
-        new DeleteGroupFileFolder(obContext, core, ncDelGroupFileFolder),
+        new DeleteGroupFileFolder(obContext, core),
         new GetGroupFileSystemInfo(obContext, core),
-        goCqHttpGetGroupRootFiles,
+        new GetGroupFilesByFolder(obContext, core),
-        new GetGroupFilesByFolder(obContext, core, goCqHttpGetGroupRootFiles),
     ];
     const actionMap = new Map();
     for (const action of actionHandlers) {

src/onebot/entities.ts

@@ -109,7 +109,7 @@ export class OB11Entities {
     static file(peerId: string, file: Exclude<GroupFileInfoUpdateParamType['item'][0]['fileInfo'], undefined>): OB11GroupFile {
         return {
             group_id: parseInt(peerId),
-            file_id: FileNapCatOneBotUUID.encodeModelId({ chatType: 2, peerUid: peerId }, file.fileModelId),
+            file_id: FileNapCatOneBotUUID.encodeModelId({ chatType: 2, peerUid: peerId }, file.fileModelId, file.fileId),
             file_name: file.fileName,
             busid: file.busId,
             size: parseInt(file.fileSize),